-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables support for IM350 #20038
Enables support for IM350 #20038
Conversation
i am not very happy with #define inside this driver try this file: the author of GcmParser.cpp (ams reader) has already patched this issue. if it works make your PR if it should not work we may think about a special option flag |
It works, but the magic values used to differentiate between the different packets are awfully close to values of the payload length. |
As it is now, it will not be merged. |
@Flo3-1 |
I have done some further testing and this code works most of the time. |
"this code works most of the time" |
It works for the packets sent by my Meter, but I have found packets online by similar meters which do not decode with the if statement. But do decode witch the define due to a collision with the magic values in the code. Therefore it works on my machine, but there is a likelihood for it to not work witch a different utility company. |
Any status on this PR? |
i simply added a descriptor flag to modify the drivers behavior via descriptor instead of an #ifdef. |
Sorry for the late comment, I was a bit busy. |
ok, since you seem to be very busy, i will do the pr since other users also requested this change. |
@gemu2015 maybe I can help, I have an IM350 from Wiener Netze, and it does not work (#8790 (comment)). Now I tried to compile a Version from the Development branch and added the 1, =soA,1 command to the Script, but decryption is not working for me… |
@dagobertch |
@gemu2015 I checked again, every block of the encrypted dump starts with 7e a0 and ends with 7e and Looks Like no missing values in between. the dump: 13:54:14.115 CMD: Sensor53 d1 edit: enabeling logging Shows: |
ok, then if your raw data is ok, is your input buffer large enough , default is 48 Bytes but you need much more. |
Oh no, seems I found the Solution: I wrote 1,=so4, key not 1,=so4,key |
Description:
Fixes the decryption code for the Simens IM350 issued by Wiener Netze
It has been implemented using the define USE_IM350 to grantee compatibility with older versions and other devices.
During dry runs also solved #18560 / #18561
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass