Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Zigbee crash when removing ZbName #21449

Merged
merged 1 commit into from
May 20, 2024
Merged

Fixed Zigbee crash when removing ZbName #21449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ All notable changes to this project will be documented in this file.
- Avoid connection errors when switching to safeboot to upload OTA firmware (#21428)
- Berry Leds matrix alternate more and error about 'bri' attribute (#21431)
- Wrong timeout in `WebQuery` and `webclient` since Core3
- Zigbee crash when removing `ZbName`

### Removed
- Support of old insecure fingerprint algorithm. Deprecated since v8.4.0 (#21417)
Expand Down
2 changes: 1 addition & 1 deletion tasmota/tasmota_xdrv_driver/xdrv_23_zigbee_2a_devices_impl.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ bool Z_Device::setEPName(uint8_t ep, const char * name) {
}

void Z_Device::setStringAttribute(char*& attr, const char * str) {
if (nullptr == str) { str = PSTR(""); } // nullptr is considered empty string
if (nullptr == str) { str = ""; } // nullptr is considered empty string, don't use PROGMEM to avoid crash
size_t str_len = strlen(str);

if ((nullptr == attr) && (0 == str_len)) { return; } // if both empty, don't do anything
Expand Down