Berry ULP: no assertion when adc_config fails #22696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is change in behavior of the ESP-IDF when configuring multiple ADC channels for the ULP of the ESP32, which make it fail for any attempt after the first one was initialised.
This unresolved issue seems to be related:
espressif/esp-idf#11160
In my tests I could not really see a degradation of functionality for the second ADC channel, although I get the error from the IDF function.
This change will just return the error code instead raising an exception, which is of questionable validity for the moment. It saves a few bytes too and is no breaking change for any program.
Additionally cleaned up the include section a bit.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass