Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry ULP: no assertion when adc_config fails #22696

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Dec 21, 2024

Description:

There is change in behavior of the ESP-IDF when configuring multiple ADC channels for the ULP of the ESP32, which make it fail for any attempt after the first one was initialised.
This unresolved issue seems to be related:
espressif/esp-idf#11160

In my tests I could not really see a degradation of functionality for the second ADC channel, although I get the error from the IDF function.

This change will just return the error code instead raising an exception, which is of questionable validity for the moment. It saves a few bytes too and is no breaking change for any program.

Additionally cleaned up the include section a bit.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241206
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit f3fcbea into arendst:development Dec 21, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants