Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning TuyaMCU code with Tasmota naming conventions #6758

Merged
merged 7 commits into from
Oct 27, 2019
Merged

Aligning TuyaMCU code with Tasmota naming conventions #6758

merged 7 commits into from
Oct 27, 2019

Conversation

blakadder
Copy link
Collaborator

Description:

Building on top of shantur's PR I changed:

  • TuyaMCUReceived to TuyaReceived to keep with established naming scheme (SerialSend/SerialReceived; TuyaSend/TuyaReceived)
  • Changed topic of TuyaReceived from tele/%topic%/RESULT to stat/%topic%/RESULT

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core pre-2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 1346f77 into arendst:development Oct 27, 2019
@shantur
Copy link
Contributor

shantur commented Oct 27, 2019

@arendst
Copy link
Owner

arendst commented Oct 27, 2019

You're right. I will adjust.

arendst added a commit that referenced this pull request Oct 27, 2019
@ascillato2 ascillato2 added this to the v7.1.0 milestone Nov 1, 2019
@ascillato2 ascillato2 added enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended labels Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants