Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check deepsleep for valid values in Settings (#6961) #6962

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

s-hadinger
Copy link
Collaborator

Description:

Value of deepsleep happen to be 0xFFFFFFFF (or -1) after some OTA scenarios. This PR resets deepsleep when the settings are out of range.

Related issue (if applicable): fixes #6961

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@s-hadinger
Copy link
Collaborator Author

@arendst I propose this hook to fix illegal deepsleep values but maybe there is a better location in the code.

@arendst
Copy link
Owner

arendst commented Nov 19, 2019

Thx. I will investigate too but for now this is fine. Sorry.

@arendst arendst merged commit 28725c5 into arendst:development Nov 19, 2019
@s-hadinger s-hadinger deleted the fix_deepsleep branch November 19, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Losing device after upgrade from 7.0.0.3 to 7.0.0.5
2 participants