Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fif le01mr #7584

Merged
merged 7 commits into from
Feb 10, 2020
Merged

Fif le01mr #7584

merged 7 commits into from
Feb 10, 2020

Conversation

saper-2
Copy link
Contributor

@saper-2 saper-2 commented Jan 23, 2020

Description:

Added driver for F&F LE-01MR Single Phase Modbus Energy meter.
I based the code on SDM-120 driver.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.6.1
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

Need to translate one added define to other languages from English to that language (I did copy-paste it from en-GB; my language pl-PL & sv-SE should be ok).
I did update some comments too (from SDM220 to "SDM120, SDM220 and LE-01MR" 😄 )

I'm also willing to update docs too 😄

@arendst
Copy link
Owner

arendst commented Jan 24, 2020

Thx.

What's the difference between the tasmota Total and your Total Active? Shouldn't they be the same? If not, did you use SetOption 72 1

@saper-2
Copy link
Contributor Author

saper-2 commented Jan 24, 2020

Total Active is a Energy counted by LE-01MR (from it's register - it can not be reset by any means). While Tasmota energy counters can be reset (e.g.: zero ESP flash and burn new tasmota firmware to ESP).

@ascillato
Copy link
Contributor

So, TOTAL ACTIVE label should be ENERGY COUNTER TOTAL?

@arendst
Copy link
Owner

arendst commented Jan 25, 2020

Yes and No. TOTAL ACTIVE is the same as the hardware counter as will be shown when SetOption72 1 is set.

With this enabled you can tell Tasmota to reset the counters to any value you like as it will substract that value from the total value provided by your device. See command EnergyReset4.

The point here is that I do not want to add another field when there is already a field for that. This way every new energy monitoring device adds it's own counters duplicating functionality that is already present.

I'm still in limbo if I want this to add.

@saper-2
Copy link
Contributor Author

saper-2 commented Jan 25, 2020

Hmmmm....
The one thing that bugging me it I would like to have both 😄 (yes, I'm very GREEDY person 😈 ): the value that I can preset in tasmota (energyReset4), and the meter counter value.

But if this bugging you that much 😁 , then I'll settle to Option72 , and let the user to decide by leaving disabled "#define" to enable this additional value in mqtt json , would be that fine?

@ascillato - yes, you can name it that, I was using name from registers description so I might not give this value best name.

@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Jan 27, 2020
@saper-2
Copy link
Contributor Author

saper-2 commented Jan 29, 2020

Then should I revert all those changes to language files? Then, I would move this additional string to driver file.

@arendst arendst merged commit 33e48df into arendst:development Feb 10, 2020
arendst added a commit that referenced this pull request Feb 10, 2020
Add support for FiF LE-01MR energy meter by saper-2 (#7584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants