Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the ElectriQ iQ-wifiMOODL RGBW LED controller #7947

Merged
merged 9 commits into from
Mar 18, 2020

Conversation

ianbyte
Copy link

@ianbyte ianbyte commented Mar 17, 2020

Description:

This PR adds support for the ElectriQ iQ-wifiMOODL RGBW LED controller:
https://www.electriq.co.uk/p/iq-wifimoodl/electriq-dimmable-colour-changing-led-smart-mood-lamp-alexa-and-google-home-compatible

This lamp uses the TYWE3S module to transmit via UART to an unmarked MCU which drives 8 MOSFETs.
The MCU does not transmit; it only receives commands from the TYWE3S.
The MCU appears to use a modified/undocumented version of the TuyaMCU protocol.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core Tasmota_core_stage
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@ascillato
Copy link
Contributor

Thanks for sharing.

This should be disabled as default in order to not increase flash usage for all users. If any user need this, he/she can self compile.

@@ -663,6 +663,7 @@
#define D_SENSOR_CC1101_GDO0 "CC1101 GDO0"
#define D_SENSOR_CC1101_GDO2 "CC1101 GDO2"
#define D_SENSOR_HRXL_RX "HRXL Rx"
#define D_SENSOR_ELECTRIQ_MOODL "ElectriQ MOODL Tx"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text too long. See remark in file:

// tasmota_template.h - keep them as short as possible to be able to fit them in GUI drop down box

Just drop ElectriQ and keep MOODL Tx in all language files

BUILDS.md Outdated
@@ -53,6 +53,7 @@
| USE_SM16716 | - | - | x | x | x | - | x |
| USE_SM2135 | - | - | x | x | x | - | x |
| USE_SONOFF_L1 | - | - | x | x | x | - | x |
| USE_ELECTRIQ_MOODL | - | - | x | x | x | - | x |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable all by default as it is a niche product

@arendst
Copy link
Owner

arendst commented Mar 18, 2020

Pls fix the above issues before merge.

BTW I love the tiny code addition for a new feature.

@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Mar 18, 2020
@arendst arendst merged commit c1d7da2 into arendst:development Mar 18, 2020
@arendst
Copy link
Owner

arendst commented Mar 18, 2020

Thx.

Considering the tine code footprint (0k3) I'll enable it by default anyway.

arendst added a commit that referenced this pull request Mar 18, 2020
Add support for ElectriQ iQ-wifiMOODL RGBW light by ianbyte (#7947)
@blakadder
Copy link
Collaborator

@ianbyte got a template for that lamp?

@arendst
Copy link
Owner

arendst commented Mar 21, 2020

To be honest any template will do as long as some GPIO is configured as MOODL Tx.

But for completeness this should do:

{"NAME":"ElectriQ MOODL","GPIO":[0,201,0,0,0,0,0,0,0,0,0,0,0],"FLAG":0,"BASE":18}

@blakadder
Copy link
Collaborator

i hoped the gpio doesn't randomly change on that lamp :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants