Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defined mcast addr for device groups instead of sharing emuation #8270

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Use defined mcast addr for device groups instead of sharing emuation #8270

merged 3 commits into from
Apr 25, 2020

Conversation

pcdiem
Copy link
Contributor

@pcdiem pcdiem commented Apr 24, 2020

Description:

Related issue (if applicable): fixes #8258

**** NOTE: This is a breaking change. This update changes the multicast address and port used by device groups. All devices using the device groups feature must be upgraded. ****

Use compile-time defined multicast address for device groups instead of sharing the emulation (SSDP) socket.

For DevGroupSend, ignore out share mask and always process locally.

Code size reductions.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core Tasmota_core
  • The code change is tested and works on core ESP32
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 209c8f4 into arendst:development Apr 25, 2020
arendst added a commit that referenced this pull request Apr 25, 2020
- Breaking Change Device Groups multicast address and port  (#8270)
- Version bump 8.2.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Groups Multicast Address
2 participants