Added Pencil II support. #1637
Open
Added Pencil II support. #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given how similar these platforms are, I can't help but think it would it be better to make it an alternate configuration of the ColecoVision core rather than an entirely new one. Take a look at how Pocket Challenge V2 is an alternate configuration in the WonderSwan core, Thoughts/feedback welcome Also this seems to lack support for the keyboard? Given that the Pencil II is a computer, don't you think that would be important to add? |
|
That would be better. Let me have a look and I'll see if I can adapt it. |
|
Did you manage to take a look at this (merged cores)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a Pencil II core based on the ColecoVision core. The timings are different as the system uses a 10.738 mhz crystal instead of the 7 mhz on the Colecovision.