fix typecode decoding DoS #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've looked at some other implementations and some seem to have implemented it the same way and are therefore also vulnerable. |
aresch
added a commit
that referenced
this pull request
Aug 10, 2021
This bug will cause rencode to hang if the invalid typecode is included in a sequence type (list, dict) since the position will not change and the loop checking for the termination byte never returns. This change is a copy of PR #29 with a few aesthetic changes.
|
I've fixed this in 572ff74 with some minor cosmetic changes. |
|
CVE-2021-40839 seems to be assigned to this issue. |
|
Could we have a release please? |
|
Yes, a release seems very much in order here. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, one can generate a bytestream which will effectively DoS the software decoding it: the cython decoder will spin at 100% CPU going through the list decoding loop (or dictionary - the same issues also exists there) forever until the system runs out of memory..
Sorry for the bad news. This looks like a CVE is in order.