Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support multiple package managers #177

Conversation

goestav
Copy link
Contributor

@goestav goestav commented Jun 29, 2024

This pull request adds support for other package managers like pnpm and yarn.

Closes #173

Copy link

changeset-bot bot commented Jun 29, 2024

🦋 Changeset detected

Latest commit: b8d7fa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@arethetypeswrong/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All looks good except for the config change.

packages/cli/tsconfig.json Outdated Show resolved Hide resolved
@andrewbranch andrewbranch merged commit e051c7f into arethetypeswrong:main Jul 2, 2024
1 check passed
@goestav
Copy link
Contributor Author

goestav commented Jul 19, 2024

Hello @andrewbranch, you're correct about pnpm not supporting custom filenames for tarballs.
I did mention that in the comment here but maybe I should've made that clear in the merge request description as well. Yarn does support it however.

What do you think about an option that lets you specify the package manager manually for the pack command? Like for example: attw --pack . --package-manager pnpm (or attw --pack . -m pnpm for short).
The default value should be npm so it doesn't break the workflow of others.

Edit: it turns my issue from #173 was relevant to this npm bug, for some reason I'm not experiencing the problem anymore now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the workspace: protocol
2 participants