Simplify old bulk endpoints to avoid create datasets if does not exists #3244
Assignees
Labels
area: api
Indicates that an issue or pull request is related to the Fast API server or REST endpoints
type: technical debt
Indicates that technical debt needs to be solved
Milestone
Comments
frascuchon
added
type: technical debt
9 tasks
9 tasks
frascuchon
added a commit
that referenced
this issue
Jul 3, 2023
…s not exists (#3306) <!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR changes the `POST /api/datasets/:dataset-id/:task/bulk` endpoints behavior to not create the dataset if does not exist. The dataset must be created first using the `POST /api/datasets` endpoint. Since version 1.10, the Python client is already adapted, but the `rg.log` may fail for older clients. Closes #3244 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [X] Refactor (change restructuring the codebase without changing functionality) **Checklist** - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
alvarobartt
pushed a commit
that referenced
this issue
Jul 4, 2023
…s not exists (#3306) <!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR changes the `POST /api/datasets/:dataset-id/:task/bulk` endpoints behavior to not create the dataset if does not exist. The dataset must be created first using the `POST /api/datasets` endpoint. Since version 1.10, the Python client is already adapted, but the `rg.log` may fail for older clients. Closes #3244 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [X] Refactor (change restructuring the codebase without changing functionality) **Checklist** - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Change old bulk API endpoints to avoid creating the dataset if does not exist. This will break old workflows, so keep in mind this t reflect in the changelog.
Refs #3162
The text was updated successfully, but these errors were encountered: