Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add unification support for the RankingQuestion #3347

Closed
davidberenstein1957 opened this issue Jul 6, 2023 · 0 comments · Fixed by #3364
Closed

[FEATURE] add unification support for the RankingQuestion #3347

davidberenstein1957 opened this issue Jul 6, 2023 · 0 comments · Fixed by #3364
Assignees
@davidberenstein1957
Labels
type: enhancement Indicates new feature requests
Milestone
v1.13.0

Comments

@davidberenstein1957
Copy link
Member

Is your feature request related to a problem? Please describe.
As of now, we do not offer code support for unifying the 'RankingQuestion'.

Describe the solution you'd like
Unification methods that align with the docs.

Describe alternatives you've considered
N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Jul 6, 2023
@davidberenstein1957 davidberenstein1957 added this to the v1.13.0 milestone Jul 7, 2023
@davidberenstein1957 davidberenstein1957 self-assigned this Jul 7, 2023
@davidberenstein1957 davidberenstein1957 linked a pull request Jul 9, 2023 that will close this issue
Feat/3347 feature add unification support for the rankingquestion #3364
Merged
11 tasks
@davidberenstein1957 davidberenstein1957 mentioned this issue Jul 9, 2023
Merged
11 tasks
@nataliaElv nataliaElv removed this from the v1.13.0 milestone Jul 13, 2023
davidberenstein1957 added a commit that referenced this issue Jul 16, 2023
@davidberenstein1957 @alvarobartt
Feat/3347 feature add unification support for the rankingquestion (#3364
0be77e3 
)

<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

- renamed `typing.py` to `types.py` to avoid import errors
- added `RankingQuestionStrategy`
- added `RankingQuestionUnification`
- added `RankingQuestion`support for the `.for_text_classification`
method for the `TrainingTaskMapping`

Closes #3347 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] New feature (non-breaking change which adds functionality)
- [X] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x]
`tests/client/feedback/test_schemas.py:test_ranking_question_strategy`
- [x]
`tests/client/feedback/training/test_schemas.py:test_task_mapping_for_text_classification`

**Checklist**

- [X] I added relevant documentation
- [X] follows the style guidelines of this project
- [X] I did a self-review of my code
- [X] I made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my
feature works
- [X] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
@frascuchon frascuchon added this to the v1.13.0 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidberenstein1957 davidberenstein1957

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

Feat/3347 feature add unification support for the rankingquestion argilla-io/argilla
3 participants
@frascuchon @davidberenstein1957 @nataliaElv