Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : front user settings #2593

Merged
merged 181 commits into from
Mar 28, 2023
Merged

Feat : front user settings #2593

merged 181 commits into from
Mar 28, 2023

Conversation

keithCuniah
Copy link
Contributor

@keithCuniah keithCuniah commented Mar 23, 2023

Description

Main branch for front part of user settings

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #2496

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

keithCuniah and others added 30 commits January 30, 2023 16:10
- Add relationship to User and Workspace models.
- Minor fixes.
@keithCuniah keithCuniah requested a review from leiyre March 23, 2023 09:59
@keithCuniah keithCuniah marked this pull request as ready for review March 23, 2023 10:07
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 93.85% and project coverage change: +0.01 🎉

Comparison is base (d687380) 93.53% compared to head (8169615) 93.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2593      +/-   ##
===========================================
+ Coverage    93.53%   93.54%   +0.01%     
===========================================
  Files          157      164       +7     
  Lines         7839     8271     +432     
===========================================
+ Hits          7332     7737     +405     
- Misses         507      534      +27     
Flag Coverage Δ
pytest 93.54% <93.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argilla/client/api.py 95.34% <ø> (-2.33%) ⬇️
src/argilla/server/routes.py 100.00% <ø> (ø)
...la/server/security/auth_provider/local/settings.py 100.00% <ø> (ø)
src/argilla/server/seeds.py 0.00% <0.00%> (ø)
src/argilla/tasks/database/migrate.py 0.00% <0.00%> (ø)
src/argilla/server/apis/v0/validators/commons.py 60.00% <60.00%> (ø)
src/argilla/client/apis/datasets.py 90.40% <66.66%> (-2.23%) ⬇️
src/argilla/client/datasets.py 85.77% <66.66%> (-0.30%) ⬇️
src/argilla/server/services/datasets.py 92.37% <85.93%> (-7.63%) ⬇️
src/argilla/server/apis/v0/handlers/workspaces.py 88.33% <88.33%> (ø)
... and 37 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments

CHANGELOG.md Outdated Show resolved Hide resolved
@frascuchon frascuchon merged commit f916e1f into develop Mar 28, 2023
@frascuchon frascuchon deleted the feature/front-user-settings branch March 28, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍓 User Settings view
4 participants