Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update field name in metadata for image url #2609

Conversation

burtenshaw
Copy link
Contributor

Description

This pull request aligns the image classification tutorial with the correct implementation by displaying images from a URL on the front end.

  • i.e. _image_url in metadata.
  • install instructions are returned to standard.

Closes #2592

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

The notebook has been run with a release v1.5.0 instance of Argilla.

Checklist

@dvsrepo
Copy link
Member

dvsrepo commented Mar 27, 2023

💯 @burtenshaw !

Could you change the base branch to main and make the PR against main instead of develop? Then we're ready to go!

This is underdocumented but for improvements to the docs it means change will be reflected on the latest docs

@burtenshaw burtenshaw changed the base branch from develop to main March 28, 2023 04:36
@burtenshaw burtenshaw changed the base branch from main to develop March 28, 2023 04:47
@burtenshaw burtenshaw changed the base branch from develop to main March 28, 2023 04:54
@burtenshaw burtenshaw closed this Mar 28, 2023
@burtenshaw burtenshaw reopened this Mar 28, 2023
@burtenshaw burtenshaw changed the base branch from main to develop March 28, 2023 05:23
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.37 ⚠️

Comparison is base (f046c5b) 93.58% compared to head (98116a1) 93.21%.

❗ Current head 98116a1 differs from pull request most recent head 0944106. Consider uploading reports for the commit 0944106 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2609      +/-   ##
===========================================
- Coverage    93.58%   93.21%   -0.37%     
===========================================
  Files          164      164              
  Lines         8274     8274              
===========================================
- Hits          7743     7713      -30     
- Misses         531      561      +30     
Flag Coverage Δ
pytest 93.21% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@burtenshaw
Copy link
Contributor Author

@dvsrepo It looks like there are a few changes in develop to this tutorial and others, including renaming (@davidberenstein1957). I would suggest this change follows those.

@frascuchon
Copy link
Member

No worries @burtenshaw @dvsrepo I can cherry-pick these changes. Thanks!!

@frascuchon frascuchon self-requested a review March 28, 2023 12:39
@frascuchon frascuchon merged commit b7a821c into argilla-io:develop Mar 28, 2023
frascuchon pushed a commit that referenced this pull request Mar 28, 2023
# Description

This pull request aligns the image classification tutorial with the
correct implementation by displaying images from a URL on the front end.

- i.e. `_image_url` in metadata.
- install instructions are returned to standard.

Closes #2592 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested**

The notebook has been run with a release v1.5.0 instance of Argilla.

**Checklist**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update image classification tutorial
3 participants