-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update field name in metadata for image url #2609
fix: update field name in metadata for image url #2609
Conversation
💯 @burtenshaw ! Could you change the base branch to main and make the PR against main instead of develop? Then we're ready to go! This is underdocumented but for improvements to the docs it means change will be reflected on the latest docs |
…hub.com/burtenshaw/argilla into fix/align-image-classification-tutorial
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #2609 +/- ##
===========================================
- Coverage 93.58% 93.21% -0.37%
===========================================
Files 164 164
Lines 8274 8274
===========================================
- Hits 7743 7713 -30
- Misses 531 561 +30
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@dvsrepo It looks like there are a few changes in develop to this tutorial and others, including renaming (@davidberenstein1957). I would suggest this change follows those. |
No worries @burtenshaw @dvsrepo I can cherry-pick these changes. Thanks!! |
# Description This pull request aligns the image classification tutorial with the correct implementation by displaying images from a URL on the front end. - i.e. `_image_url` in metadata. - install instructions are returned to standard. Closes #2592 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** The notebook has been run with a release v1.5.0 instance of Argilla. **Checklist**
Description
This pull request aligns the image classification tutorial with the correct implementation by displaying images from a URL on the front end.
_image_url
in metadata.Closes #2592
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
The notebook has been run with a release v1.5.0 instance of Argilla.
Checklist