feat: add FeedbackDataset search endpoint
#3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
added
type: enhancement
gabrielmbmb
changed the title
FeedbackDataset search endpoint
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3068 +/- ##
===========================================
+ Coverage 90.77% 90.79% +0.02%
===========================================
Files 208 209 +1
Lines 11199 11237 +38
===========================================
+ Hits 10166 10203 +37
- Misses 1033 1034 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gabrielmbmb
commented
Jun 2, 2023
frascuchon
reviewed
Jun 5, 2023
frascuchon
reviewed
Jun 5, 2023
Co-authored-by: Francisco Aranda <francis@argilla.io>
frascuchon
reviewed
Jun 5, 2023
gabrielmbmb
force-pushed
the
feature/search-endpoint
branch
from
6b35632 to
75717b3
Compare
frascuchon
reviewed
Jun 5, 2023
frascuchon
reviewed
Jun 5, 2023
There was a problem hiding this comment.
We can keep this definition here, but maybe in the future, we should consider moving it into the search module.
frascuchon
approved these changes
Jun 5, 2023
frascuchon
approved these changes
Jun 5, 2023
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 5, 2023
# Description
This PR introduces a new endpoint `POST
/api/v1/me/datasets/{dataset_id}/records/search` that will allow the
user to search records using some basic queries over the fields.
Closes #3067
**Type of change**
- [x] New feature (non-breaking change which adds functionality)
**How Has This Been Tested**
New unit tests have been added to test the functionality of this new
endpoint. In addition, I manually tested the endpoint using the Argilla
dolly dataset.
**Checklist**
- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: Francisco Aranda <francis@argilla.io>
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 7, 2023
# Description
This PR introduces a new endpoint `POST
/api/v1/me/datasets/{dataset_id}/records/search` that will allow the
user to search records using some basic queries over the fields.
Closes #3067
**Type of change**
- [x] New feature (non-breaking change which adds functionality)
**How Has This Been Tested**
New unit tests have been added to test the functionality of this new
endpoint. In addition, I manually tested the endpoint using the Argilla
dolly dataset.
**Checklist**
- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: Francisco Aranda <francis@argilla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new endpoint
POST /api/v1/me/datasets/{dataset_id}/records/searchthat will allow the user to search records using some basic queries over the fields.Closes #3067
Type of change
How Has This Been Tested
New unit tests have been added to test the functionality of this new endpoint. In addition, I manually tested the endpoint using the Argilla dolly dataset.
Checklist