feat: admin role will be scoped to workspaces #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
force-pushed
the
feat/admin-role-will-be-scoped-to-workspaces
branch
from
79d785d to
acd03d8
Compare
…feat/admin-role-will-be-scoped-to-workspaces
alvarobartt
reviewed
Jun 13, 2023
alvarobartt
reviewed
Jun 13, 2023
…feat/admin-role-will-be-scoped-to-workspaces
gabrielmbmb
approved these changes
Jun 14, 2023
| @@ -63,7 +63,7 @@ def create_dataset(self, user: User, dataset: CreateDatasetRequest) -> BaseDatas | |||
| if not accounts.get_workspace_by_name(self._db, workspace_name=dataset.workspace): | |||
| raise EntityNotFoundError(name=dataset.workspace, type=Workspace) | |||
|
|
|||
| if not is_authorized(user, DatasetPolicy.create): | |||
| if not is_authorized(user, DatasetPolicy.create(workspace_name=dataset.workspace)): | |||
| raise ForbiddenOperationError( | |||
| "You don't have the necessary permissions to create datasets. Only administrators can create datasets" | |||
There was a problem hiding this comment.
When we write administrators, we mean both the role of owner and admin, right?
There was a problem hiding this comment.
yes, we can see the owner role as an extended role from admin
Co-authored-by: Gabriel Martín Blázquez <gmartinbdev@gmail.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings changed to support 3 kinds of roles:
owner: full access (oldadminrole)admin: workspace-level operations (create/delete datasets, add records,...)annotator: same as before. Just for annotation purposes.Most of the tests have been revisited regarding the
mocked_clientfixture. I've also added variations o tests to support most roles as possible for the tested functionality. Since a huge number of changes have been included here, I will add more details in future PRs.Refs #3094
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Tests have been updated
Checklist