Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow visible_labels=None & disallow fields/questions with the same name #3126

Merged
merged 7 commits into from
Jun 8, 2023

Conversation

alvarobartt
Copy link
Member

Description

This PR solves two minor fixes reported before the 1.9.0 release related to the validations to make sure that:

  • visible_labels in LabelQuestion and/or MultiLabelQuestion can be set to None so that all the labels show in the Argilla UI
  • The fields and questions of a FeedbackDataset cannot have the same name, otherwise, a ValueError should be raised

Closes #3034, #3123

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Add unit tests for visible_labels=None to make sure it's kept and not replaced by default 20
  • Add unit tests for FeedbackDataset init with duplicated field and question names

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added this to the v1.9.0 milestone Jun 8, 2023
@alvarobartt alvarobartt requested a review from frascuchon June 8, 2023 12:47
@alvarobartt alvarobartt linked an issue Jun 8, 2023 that may be closed by this pull request
@alvarobartt alvarobartt self-assigned this Jun 8, 2023
@alvarobartt alvarobartt requested a review from gabrielmbmb June 8, 2023 12:49
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to show links properly in the CHANGELOG.md

@frascuchon frascuchon merged commit 549b350 into develop Jun 8, 2023
@frascuchon frascuchon deleted the fix/fields-and-questions-validations branch June 8, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated question error message upon creating dataset Disallow fields and/or questions with same name
2 participants