fix: allow visible_labels=None
& disallow fields
/questions
with the same name
#3126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves two minor fixes reported before the 1.9.0 release related to the validations to make sure that:
visible_labels
inLabelQuestion
and/orMultiLabelQuestion
can be set toNone
so that all the labels show in the Argilla UIFeedbackDataset
cannot have the same name, otherwise, aValueError
should be raisedCloses #3034, #3123
Type of change
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)visible_labels=None
to make sure it's kept and not replaced by default 20FeedbackDataset
init with duplicated field and question namesChecklist