fix: unhandled ImportError
on huggingface_hub
#3174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported by @dvsrepo, when installing
argilla
without any extra dependency, an unhandledImportError
is raised. That's due to the import ofArgillaDatasetCard
being on top of the file instead of under the@requires_version
decorator, so that theImportError
will still be raised, but at least it will be handled.Also the
ImportError
was being triggered just when importing theFeedbackDataset
class as it was on top of the file, which was obviously wrong, as it should just raise when callingpush_to_huggingface
.Type of change
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)from argilla.client.feedback.dataset import FeedbackDataset
doesn't raise anImportError
whenhuggingface_hub
is not installedChecklist