-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply proper serializer when pushing feedback dataset in Argilla #3192
Apply proper serializer when pushing feedback dataset in Argilla #3192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor comments regarding the json.loads(schema.json())
, and about the removal of .dict(includes=set())
🤗
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3192 +/- ##
===========================================
- Coverage 90.91% 90.69% -0.22%
===========================================
Files 215 215
Lines 11304 11318 +14
===========================================
- Hits 10277 10265 -12
- Misses 1027 1053 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Description
By default, the
model.dict()
method won't apply custom serialization to theUUID
ordatetatime
fields. Since pydantic provides a.json
method which applies serialization properly, we should use them in order to support pushing data in Argilla.The current solution may be improved since we're serializing more times than needed. But for that, we should change the sdk.v1.api layer. See issue #3191
Closes #3189
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)New tests have been added
Checklist