feat: add tqdm bar in FeedbackDataset.push_to_argilla #3233
Conversation
Added description Co-authored-by: Alvaro Bartolome <alvarobartt@gmail.com>
for more information, see https://pre-commit.ci
|
Hi again @manulpatel thanks again for the great work! I think we can merge this PR right after #3234 since we're also fixing some bugs there, would you mind updating the |
|
Sure! Np! I need to add my changes under |
Right! Under 1.11.0 as we'll be releasing it tomorrow! |
| @@ -581,7 +586,7 @@ def delete_dataset(dataset_id: UUID) -> None: | |||
| datasets_api_v1.add_records( | |||
| client=httpx_client, | |||
| id=argilla_id, | |||
| records=[json.loads(record.json()) for record in batch], | |||
| records=[json.loads(record.dict()) for record in tqdm(batch)], | |||
There was a problem hiding this comment.
This won't work! json.loads expects either a str or bytes. Can you revert this change?
There was a problem hiding this comment.
Indeed that's already modified in the #3234 branch as mentioned below! But yes, that would run into conflicts once the other PR is merged into develop
|
Also @manulpatel make sure to install the |
|
@alvarobartt So sorry. Actually I have installed the pre-commit hooks locally but the above commit I did directly from github editor, which didn't run the . In the next commits I will ensure this strictly. |
No worries at all @manulpatel 😄 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3233 +/- ##
========================================
Coverage 91.00% 91.00%
========================================
Files 219 219
Lines 11672 11672
========================================
Hits 10622 10622
Misses 1050 1050
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description Add a `tqdm ` progress bar to `FeedbackDataset.push_to_argilla` when looping over the records to upload, either if those are all the records in records or just the latest/new records in __new_records. Closes #3119 **Type of change** - [x] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** Manully ran a test.py to push a dataset to argilla and checked the appreance of `tqdm `bar in the terminal while adding records. **Checklist** - [ ] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Alvaro Bartolome <alvarobartt@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Add a
tqdmprogress bar toFeedbackDataset.push_to_argillawhen looping over the records to upload, either if those are all the records in records or just the latest/new records in __new_records.Closes #3119
Type of change
How Has This Been Tested
Manully ran a test.py to push a dataset to argilla and checked the appreance of
tqdmbar in the terminal while adding records.Checklist