Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: master mention as described in #2324 #3254

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

garimau
Copy link
Contributor

@garimau garimau commented Jun 23, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

I changed the mention of master branch to main/develop branch. (Really minor, but I also just removed the hyphen in the warning for new versions of docker-compose, as it said.
Closes #2324

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

N.A.

Checklist

Copy link
Contributor

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidberenstein1957 davidberenstein1957 merged commit e516c94 into argilla-io:develop Jun 23, 2023
@garimau garimau deleted the 2324-master-mention branch June 23, 2023 19:40
@garimau garimau restored the 2324-master-mention branch June 23, 2023 19:40
davidberenstein1957 pushed a commit that referenced this pull request Jun 26, 2023
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

I changed the mention of `master branch` to `main/develop branch`.
(Really minor, but I also just removed the hyphen in the warning for new
versions of `docker-compose`, as it said.
Closes #2324

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

N.A.

**Checklist**
- [X] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
davidberenstein1957 pushed a commit that referenced this pull request Jun 26, 2023
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

I changed the mention of `master branch` to `main/develop branch`.
(Really minor, but I also just removed the hyphen in the warning for new
versions of `docker-compose`, as it said.
Closes #2324

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

N.A.

**Checklist**
- [X] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
davidberenstein1957 pushed a commit that referenced this pull request Jun 26, 2023
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

I changed the mention of `master branch` to `main/develop branch`.
(Really minor, but I also just removed the hyphen in the warning for new
versions of `docker-compose`, as it said.
Closes #2324

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

N.A.

**Checklist**
- [X] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
damianpumar pushed a commit that referenced this pull request Jun 27, 2023
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

I changed the mention of `master branch` to `main/develop branch`.
(Really minor, but I also just removed the hyphen in the warning for new
versions of `docker-compose`, as it said.
Closes #2324

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

N.A.

**Checklist**
- [X] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: mentions of master branch/version/image when we use develop/main now
3 participants