feat: delete record endpoint #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
commented
Jul 4, 2023
frascuchon
reviewed
Jul 6, 2023
frascuchon
reviewed
Jul 6, 2023
frascuchon
reviewed
Jul 6, 2023
frascuchon
reviewed
Jul 6, 2023
Co-authored-by: Francisco Aranda <francis@argilla.io>
for more information, see https://pre-commit.ci
frascuchon
approved these changes
Jul 6, 2023
Shouldn't we return 404 in that case? As we want to state that the introduced record IDs were not found, right? |
gabrielmbmb
force-pushed
the
feature/delete-records-endpoints
branch
from
ad90ded
to
d73729f
Compare
gabrielmbmb
changed the title
gabrielmbmb
force-pushed
the
feature/delete-records-endpoints
branch
from
54a17d4
to
717a776
Compare
frascuchon
reviewed
Aug 1, 2023
keithCuniah
pushed a commit
that referenced
this pull request
Aug 3, 2023
# Description
This PR adds one new endpoint for deleting records:
- `DELETE /api/v1/records/{record_id}`: for removing a specific record
given its ID.
It's been needed to add a new method `delete_records` to the
`SearchEngine` that will remove the records also from the index created
for the dataset in Elastic Search.
Closes #3310
**Type of change**
- [x] New feature (non-breaking change which adds functionality)
**How Has This Been Tested**
Manually in a local environment and I've added unit tests.
**Checklist**
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: Francisco Aranda <francis@argilla.io>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds one new endpoint for deleting records:
DELETE /api/v1/records/{record_id}: for removing a specific record given its ID.It's been needed to add a new method
delete_recordsto theSearchEnginethat will remove the records also from the index created for the dataset in Elastic Search.Closes #3310
Type of change
How Has This Been Tested
Manually in a local environment and I've added unit tests.
Checklist