fix: upsert not working because sqlite3 version
#3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
added
the
type: bug
frascuchon
reviewed
Jul 18, 2023
docker/quickstart.Dockerfile
Outdated
| # Install Elasticsearch and configure it | ||
| apt-get update && apt-get install -y elasticsearch=8.8.2 && \ | ||
| mkdir /usr/share/elasticsearch/config && \ | ||
| echo "cluster.name: \"docker-cluster\"\nnetwork.host: 0.0.0.0\npath.data: \"/data/elasticsearch\"bootstrap.system_call_filter: false" > /usr/share/elasticsearch/config/elasticsearch.yml && \ |
There was a problem hiding this comment.
Not sure if is possible but we could use just the defined ARGILLA_HOME as the parent path for the elasticsearch data. $ARGILLA_HOME/elasticsearch
There was a problem hiding this comment.
Or just bypass the ARGILLA_HOME definition and force the value to /data
There was a problem hiding this comment.
some lines below we're doing ENV ARGILLA_HOME_PATH=/data/argilla
frascuchon
reviewed
Jul 18, 2023
frascuchon
reviewed
Jul 18, 2023
There was a problem hiding this comment.
at some point of this file we can force the ARGILLA_HOME_PATH to /data
There was a problem hiding this comment.
we're forcing it to /data/argilla
gabrielmbmb
force-pushed
the
fix/upsert-fails-sqlite3
branch
10 times, most recently
from
6367db1
to
fc85cef
Compare
gabrielmbmb
force-pushed
the
fix/upsert-fails-sqlite3
branch
from
fc85cef
to
af37495
Compare
frascuchon
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs updates the
Dockerfileparent image frompython:3.9.16-slimtopython:3.10.12-slim, which comes withsqlite3==3.40.1installed.In addition, the
quickstart.Dockerfilehas been updated to:argilla/argilla-server:latestas parent imageelasticsearchas described in https://www.elastic.co/guide/en/elasticsearch/reference/current/deb.html#debThis way, the
Dockerfileandquickstart.Dockerfileare aligned using the same system dependencies, python dependencies and Python version.Finally, a new workflow has been added
build-push-docker.ymlwhich builds and push the Docker image and has the version of the build docker image as output. It's been needed to add this, as for building theargilla/argilla-quickstartwe need to pass the build argumentARGILLA_VERSIONwith the desired value of theargilla/argilla-server.Closes #3423
Type of change
How Has This Been Tested
pre.argilla.io1.12.0upgrade to1.13.0. The data is not lost.Checklist