Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove type creation for postgresql #3438

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

frascuchon
Copy link
Member

Description

The last alembic migration definitions fail when using PostgreSQL as the database. This PR fixes this by allowing upgrade and downgrade properly. For more info about the problem, see here sqlalchemy/alembic#886

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Changes have been tested using a local database to apply migrations (update and downgrade)

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.41 ⚠️

Comparison is base (f8a5c0c) 90.29% compared to head (45f888d) 89.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3438      +/-   ##
==========================================
- Coverage   90.29%   89.88%   -0.41%     
==========================================
  Files         243      243              
  Lines       13226    13226              
==========================================
- Hits        11942    11888      -54     
- Misses       1284     1338      +54     

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit 6ca128f into main Jul 21, 2023
19 checks passed
@frascuchon frascuchon deleted the hotfixes/correct-postgresql-db-migrations branch July 21, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant