Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify which assignment method to follow based on the dataset type #3457

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

nataliaElv
Copy link
Member

@nataliaElv nataliaElv commented Jul 26, 2023

Description

Changes guides to assign annotations to make clear which method to follow based on the type of dataset used.

Closes #3360

Type of change

  • Documentation update

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@nataliaElv nataliaElv marked this pull request as ready for review July 26, 2023 11:58
@nataliaElv nataliaElv linked an issue Jul 26, 2023 that may be closed by this pull request
@nataliaElv nataliaElv changed the title docs: clarify dataset types docs: clarify which assignment method to follow based on the dataset type Jul 26, 2023
nataliaElv added a commit that referenced this pull request Jul 27, 2023
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor comments regarding the notes and the reference to the TokenClassificationDataset tutorial 👍

@nataliaElv nataliaElv merged commit 4f449ec into main Aug 16, 2023
12 of 13 checks passed
@nataliaElv nataliaElv deleted the docs/3360 branch August 16, 2023 08:20
artikandri pushed a commit to CLARIN-PL/argilla that referenced this pull request Oct 30, 2023
…type (argilla-io#3457)

# Description

Changes guides to assign annotations to make clear which method to
follow based on the type of dataset used.

Closes argilla-io#3360 

**Type of change**

- [x] Documentation update

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [x] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Clarify methods to assign annotations per dataset type
2 participants