feat: add login function for storing Argilla credentials
#3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
force-pushed
the
feature/local-credentials
branch
from
c35df01 to
82ad0d3
Compare
gabrielmbmb
force-pushed
the
feature/local-credentials
branch
from
60051d2 to
03ea530
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3582 +/- ##
===========================================
+ Coverage 90.52% 90.53% +0.01%
===========================================
Files 256 257 +1
Lines 13577 13624 +47
===========================================
+ Hits 12290 12335 +45
- Misses 1287 1289 +2
☔ View full report in Codecov by Sentry. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3582-ki24f765kq-no.a.run.app |
9 tasks
alvarobartt
approved these changes
Aug 21, 2023
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
for more information, see https://pre-commit.ci
alvarobartt
reviewed
Aug 21, 2023
alvarobartt
reviewed
Aug 21, 2023
gabrielmbmb
force-pushed
the
feature/local-credentials
branch
from
74ca678 to
a95dd47
Compare
gabrielmbmb
added a commit
that referenced
this pull request
Aug 29, 2023
# Description **NOTE**: This PR is not ready yet, it assumes the [PR 3582](#3582) is already integrated. This PR adds a new cli command `python -m argilla workspaces list`. Closes #3587 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** No tests were done yet. Maybe a new module under `tests/unit/tasks` should be added? In that case, the current implementation (when properly logged), prints to the console a table like:  **Checklist** - [ ] I added relevant documentation - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: gabrielmbmb <gmartinbdev@gmail.com>
artikandri
pushed a commit
to CLARIN-PL/argilla
that referenced
this pull request
Oct 30, 2023
…o#3582) # Description This PR includes a new function called `login` that will try to login to the Argilla server using the provided credentials. If it success, the provided credentials will be saved to `~/.cache/argilla/credentials.json` file. The `argilla.client.client.Argilla.__init__` method has been updated to try to use the stored credentials if the `api_url` and `api_key` arguments are not provided. Closes argilla-io#3581 **Type of change** - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** I've added unit tests and tried in a local development environment that `rg.init` works using the three options: providing credentials via function arguments, via environment variables and loading them from the stored file. **Checklist** - [ ] I added relevant documentation - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: Alvaro Bartolome <alvaro@argilla.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a new function called
loginthat will try to login to the Argilla server using the provided credentials. If it success, the provided credentials will be saved to~/.cache/argilla/credentials.jsonfile. Theargilla.client.client.Argilla.__init__method has been updated to try to use the stored credentials if theapi_urlandapi_keyarguments are not provided.Closes #3581
Type of change
How Has This Been Tested
I've added unit tests and tried in a local development environment that
rg.initworks using the three options: providing credentials via function arguments, via environment variables and loading them from the stored file.Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)