Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logout command #3605

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

eshwarhs
Copy link
Contributor

Description

This PR adds the logout command that will allow to logout from Argilla server and remove the locally stored credentials.

Closes #3585

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Tested manually in a local development environment and added tests to cover the additions and changes.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.05% ⚠️

Comparison is base (9a1f1c6) 90.53% compared to head (a65cdf3) 90.49%.
Report is 1 commits behind head on develop.

❗ Current head a65cdf3 differs from pull request most recent head a96692e. Consider uploading reports for the commit a96692e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3605      +/-   ##
===========================================
- Coverage    90.53%   90.49%   -0.05%     
===========================================
  Files          261      264       +3     
  Lines        13768    13807      +39     
===========================================
+ Hits         12465    12494      +29     
- Misses        1303     1313      +10     
Files Changed Coverage Δ
src/argilla/client/logout.py 47.05% <47.05%> (ø)
src/argilla/tasks/logout/__main__.py 94.73% <94.73%> (ø)
src/argilla/__main__.py 100.00% <100.00%> (ø)
src/argilla/tasks/__init__.py 100.00% <100.00%> (ø)
src/argilla/tasks/logout/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gabrielmbmb gabrielmbmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshwarhs Thansk for your pull request! I wrote you some comments that needs to be addressed before we can merge this branch.

src/argilla/tasks/logout/__main__.py Outdated Show resolved Hide resolved
src/argilla/tasks/logout/__main__.py Outdated Show resolved Hide resolved
src/argilla/client/logout.py Outdated Show resolved Hide resolved
@davidberenstein1957
Copy link
Member

Awesome @eshwarhs, this is really useful :)

@eshwarhs eshwarhs requested a review from gabrielmbmb August 23, 2023 17:16
@gabrielmbmb gabrielmbmb merged commit bb6b371 into argilla-io:develop Aug 28, 2023
@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests client labels Aug 28, 2023
@gabrielmbmb gabrielmbmb added this to the v1.15.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add logout command python -m argilla logout
3 participants