Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Enums to enums #3620

Merged
merged 2 commits into from
Aug 23, 2023
Merged

refactor: move Enums to enums #3620

merged 2 commits into from
Aug 23, 2023

Conversation

gabrielmbmb
Copy link
Member

Description

This PR moves all the Enum classes of the Argilla server to the argilla.server.enums module in order to avoid circular imports, and to have one single file in which find all the enums (they are used across all the server codebase).

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb force-pushed the feat/move-server-enums branch from d10696e to ec4a1d0 Compare August 23, 2023 14:18
@gabrielmbmb gabrielmbmb marked this pull request as ready for review August 23, 2023 14:31
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes a lot of sense! My only concern is whether we should also include the V1 at the end of each Enum to differentiate v0 from v1 enums, or whether we should just split those in different modules, WDYT?

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.60% 🎉

Comparison is base (6630d7b) 90.13% compared to head (eeadd92) 90.73%.
Report is 190 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3620      +/-   ##
===========================================
+ Coverage    90.13%   90.73%   +0.60%     
===========================================
  Files          233      261      +28     
  Lines        12493    13768    +1275     
===========================================
+ Hits         11261    12493    +1232     
- Misses        1232     1275      +43     
Flag Coverage Δ
pytest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 184 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabrielmbmb gabrielmbmb merged commit 9a1f1c6 into develop Aug 23, 2023
@gabrielmbmb gabrielmbmb deleted the feat/move-server-enums branch August 23, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants