Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cli : add python -m argilla workspaces create command #3676

Merged
merged 16 commits into from
Sep 1, 2023

Conversation

eshwarhs
Copy link
Contributor

Description

This PR adds a new CLI command python -m argilla workspaces create.

Closes #3586

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Unit tests have been added to tests/unit/tasks/workspaces directory

  • Create workspace without logging in
  • Create workspace without providing workspace name
  • Create a workspace with the same name
  • Create workspace after logging in and providing workspace name

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added the area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) label Aug 31, 2023
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor comments regarding the create_workspace function 👍🏻

src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
tests/unit/tasks/workspaces/test_create.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor details before merging!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
Copy link
Member

@gabrielmbmb gabrielmbmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @eshwarhs! It looks good to me, we need to change just a few small details.

src/argilla/tasks/workspaces/__main__.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
src/argilla/tasks/workspaces/create.py Outdated Show resolved Hide resolved
tests/unit/tasks/workspaces/test_create.py Outdated Show resolved Hide resolved
@gabrielmbmb gabrielmbmb merged commit 7c1b236 into argilla-io:develop Sep 1, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add create workspace command python -m argilla workspaces create
3 participants