Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing metadata property item limits #3975

Merged
merged 3 commits into from
Oct 18, 2023
Merged

feat: add missing metadata property item limits #3975

merged 3 commits into from
Oct 18, 2023

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Oct 17, 2023

Description

add a maximum number of items limit to TermsMetadataPropertyCreate and RankingQuestionSettingsCreate

This PR adds the following changes:

  • A maximum number of 250 items to TermsMetadataPropertyCreate.
  • A maximum number of 50 items to RankingQuestionSettingsCreate.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Running unit tests locally.
  • Running unit tests locally using PostgreSQL.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo mentioned this pull request Oct 17, 2023
Closed
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3975-ki24f765kq-no.a.run.app

@jfcalvo jfcalvo merged commit 99af881 into feature/support-for-metadata-filtering-and-sorting Oct 18, 2023
@jfcalvo jfcalvo deleted the feature/add-missing-metadata-property-item-limits branch October 18, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmbmb gabrielmbmb gabrielmbmb approved these changes

@frascuchon frascuchon Awaiting requested review from frascuchon

@alvarobartt alvarobartt Awaiting requested review from alvarobartt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfcalvo @gabrielmbmb