Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve the FeedbackDataset.__repr__ method #4103

Conversation

kursathalat
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #3935

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@kursathalat kursathalat self-assigned this Oct 31, 2023
@kursathalat kursathalat linked an issue Oct 31, 2023 that may be closed by this pull request
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
.../argilla/client/feedback/dataset/remote/dataset.py 93.14% <100.00%> (+0.02%) ⬆️

📢 Thoughts on this report? Let us know!

Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4103-ki24f765kq-no.a.run.app

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kursathalat, I am not sure if the current formatting makes it more readable for me, could you try to play around with this a bit more and potentially align with the local FeedbackDataset and include the metadata-properties. Also, you left a unused import.

@kursathalat
Copy link
Contributor Author

The problem with the current case is that when you are in a smaller screen, longer lines are wrapped improperly which looks messy. Here is the old version and new version (both looks proper on a bigger screen). If tabulate or any other library offers proper wrapping, we can iterate over the new one.

Ekran Resmi 2023-11-08 17 37 21
Ekran Resmi 2023-11-08 17 37 34

@davidberenstein1957
Copy link
Member

closing this in favour of #4192

@damianpumar damianpumar deleted the 3935-improvement-improve-the-feedbackdataset__repr__-method branch April 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Improve the FeedbackDataset.__repr__ method
2 participants