Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] argilla: normalize records when exporting flatten #5138

Merged
merged 9 commits into from
Jul 3, 2024
Merged

[BUGFIX] argilla: normalize records when exporting flatten #5138

merged 9 commits into from
Jul 3, 2024

Conversation

frascuchon
Copy link
Member

Pull Request Template

Note

This PR should be merged after merge #5137

This PR addresses problems when exporting records to dicts including records partially filled. This PR fixes the errors commented in #4936 (comment)

Close #4936

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon self-assigned this Jul 1, 2024
burtenshaw
burtenshaw approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would just like to understand the casting of question values to hf dataset features.

argilla/src/argilla/records/_io/_datasets.py Outdated Show resolved Hide resolved
argilla/tests/unit/test_io/test_hf_datasets.py Show resolved Hide resolved
@frascuchon frascuchon force-pushed the bugfix/argilla/normalize-records-when-exporting-flatten branch from f63fadc to d030550 Compare July 3, 2024 09:31
@burtenshaw
docs: update docs for flatten (#5147)
fb7b4bd 
This PR updates the docs of the flatten param in the `to_list` method.

Co-authored-by: Ben Burtenshaw <benjamin.burtenshaw@huggingface.co>
@frascuchon frascuchon merged commit 237034e into develop Jul 3, 2024
7 checks passed
@frascuchon frascuchon deleted the bugfix/argilla/normalize-records-when-exporting-flatten branch July 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtenshaw burtenshaw burtenshaw approved these changes

Assignees

@frascuchon frascuchon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Review record flatten process
2 participants
@frascuchon @burtenshaw