Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added deployment logic #64

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

added deployment logic #64

wants to merge 32 commits into from

Conversation

saargon
Copy link
Contributor

@saargon saargon commented Jul 4, 2023

No description provided.

@@ -68,3 +69,16 @@ jobs:
--aqua-secret "${{ secrets.AQUA_SECRET }}" \
--artifact-path "saargondocker/graphql-vuln:${{ github.sha }}"

deploy:
name: deploy to k8s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency aws-actions/configure-aws-credentials v1 version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

@@ -68,3 +69,16 @@ jobs:
--aqua-secret "${{ secrets.AQUA_SECRET }}" \
--artifact-path "saargondocker/graphql-vuln:${{ github.sha }}"

deploy:
name: deploy to k8s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency steebchen/kubectl-setup v1 version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

@@ -68,3 +69,13 @@ jobs:
--aqua-secret "${{ secrets.AQUA_SECRET }}" \
--artifact-path "saargondocker/graphql-vuln:${{ github.sha }}"

deploy:
name: deploy to k8s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency aws-actions/configure-aws-credentials v2 version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

name: deploy to k8s
runs-on: ubuntu-latest
permissions:
id-token: write
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected sensitive data in your code

Category: Env Generic
Description: Env Generic Credential
Severity: HIGH
Match: id-token: *****
[This comment was created by Aqua Pipeline]

@@ -68,3 +68,16 @@ jobs:
--aqua-secret "${{ secrets.AQUA_SECRET }}" \
--artifact-path "saargondocker/graphql-vuln:${{ github.sha }}"

deploy:
name: deploy to k8s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency aws-actions/configure-aws-credentials v3 version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

@@ -68,3 +68,19 @@ jobs:
--aqua-secret "${{ secrets.AQUA_SECRET }}" \
--artifact-path "saargondocker/graphql-vuln:${{ github.sha }}"

deploy:
name: deploy to k8s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency aws-actions/amazon-ecr-login v1 version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

IMAGE_TAG: ${{ github.sha }}
steps:
- name: Checkout code
uses: actions/checkout@v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0005
Check Name: persist-credentials is true
Severity: HIGH
Message: Consider adding persist-credentials: false to the checkout action in job 'build image & push to ECR' inputs
Resolution: Add persist-credentials: false to the checkout action
[This comment was created by Aqua Pipeline]

deployment.yml Outdated
Comment on lines 20 to 27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0001
Check Name: Process can elevate its own privileges
Severity: MEDIUM
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.allowPrivilegeEscalation' to false
Resolution: Set 'set containers[].securityContext.allowPrivilegeEscalation' to 'false'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv001

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0020
Check Name: Runs with low user ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsUser' > 10000
Resolution: Set 'containers[].securityContext.runAsUser' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv020

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0021
Check Name: Runs with low group ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsGroup' > 10000
Resolution: Set 'containers[].securityContext.runAsGroup' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv021

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0030
Check Name: Default Seccomp profile not set
Severity: LOW
Message: Either Pod or Container should set 'securityContext.seccompProfile.type' to 'RuntimeDefault'
Resolution: Set 'spec.securityContext.seccompProfile.type', 'spec.containers[].securityContext.seccompProfile' and 'spec.initContainers[].securityContext.seccompProfile' to 'RuntimeDefault' or undefined.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv030

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0106
Check Name: Container capabilities must only include NET_BIND_SERVICE
Severity: LOW
Message: container should drop all
Resolution: Set 'spec.containers[].securityContext.capabilities.drop' to 'ALL' and only add 'NET_BIND_SERVICE' to 'spec.containers[].securityContext.capabilities.add'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv106

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0018
Check Name: Memory not limited
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'resources.limits.memory'
Resolution: Set a limit value under 'containers[].resources.limits.memory'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv018

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0020
Check Name: Runs with low user ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsUser' > 10000
Resolution: Set 'containers[].securityContext.runAsUser' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv020

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0021
Check Name: Runs with low group ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsGroup' > 10000
Resolution: Set 'containers[].securityContext.runAsGroup' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv021

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0030
Check Name: Default Seccomp profile not set
Severity: LOW
Message: Either Pod or Container should set 'securityContext.seccompProfile.type' to 'RuntimeDefault'
Resolution: Set 'spec.securityContext.seccompProfile.type', 'spec.containers[].securityContext.seccompProfile' and 'spec.initContainers[].securityContext.seccompProfile' to 'RuntimeDefault' or undefined.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv030

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0106
Check Name: Container capabilities must only include NET_BIND_SERVICE
Severity: LOW
Message: container should drop all
Resolution: Set 'spec.containers[].securityContext.capabilities.drop' to 'ALL' and only add 'NET_BIND_SERVICE' to 'spec.containers[].securityContext.capabilities.add'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv106

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0018
Check Name: Memory not limited
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'resources.limits.memory'
Resolution: Set a limit value under 'containers[].resources.limits.memory'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv018

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0020
Check Name: Runs with low user ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsUser' > 10000
Resolution: Set 'containers[].securityContext.runAsUser' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv020

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0021
Check Name: Runs with low group ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsGroup' > 10000
Resolution: Set 'containers[].securityContext.runAsGroup' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv021

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0030
Check Name: Default Seccomp profile not set
Severity: LOW
Message: Either Pod or Container should set 'securityContext.seccompProfile.type' to 'RuntimeDefault'
Resolution: Set 'spec.securityContext.seccompProfile.type', 'spec.containers[].securityContext.seccompProfile' and 'spec.initContainers[].securityContext.seccompProfile' to 'RuntimeDefault' or undefined.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv030

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0106
Check Name: Container capabilities must only include NET_BIND_SERVICE
Severity: LOW
Message: container should drop all
Resolution: Set 'spec.containers[].securityContext.capabilities.drop' to 'ALL' and only add 'NET_BIND_SERVICE' to 'spec.containers[].securityContext.capabilities.add'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv106

docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
deploy:
name: deploy to k8s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency kodermax/kubectl-aws-eks master version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0018
Check Name: Memory not limited
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'resources.limits.memory'
Resolution: Set a limit value under 'containers[].resources.limits.memory'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv018

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0020
Check Name: Runs with low user ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsUser' > 10000
Resolution: Set 'containers[].securityContext.runAsUser' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv020

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0021
Check Name: Runs with low group ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsGroup' > 10000
Resolution: Set 'containers[].securityContext.runAsGroup' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv021

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0030
Check Name: Default Seccomp profile not set
Severity: LOW
Message: Either Pod or Container should set 'securityContext.seccompProfile.type' to 'RuntimeDefault'
Resolution: Set 'spec.securityContext.seccompProfile.type', 'spec.containers[].securityContext.seccompProfile' and 'spec.initContainers[].securityContext.seccompProfile' to 'RuntimeDefault' or undefined.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv030

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0106
Check Name: Container capabilities must only include NET_BIND_SERVICE
Severity: LOW
Message: container should drop all
Resolution: Set 'spec.containers[].securityContext.capabilities.drop' to 'ALL' and only add 'NET_BIND_SERVICE' to 'spec.containers[].securityContext.capabilities.add'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv106

docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
deploy:
name: deploy to k8s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-PIPELINE-0008
Check Name: Unrestricted dependency version
Severity: MEDIUM
Message: Dependency kodermax/kubectl-aws-eks master version should be pinned to the commit sha
[This comment was created by Aqua Pipeline]

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0018
Check Name: Memory not limited
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'resources.limits.memory'
Resolution: Set a limit value under 'containers[].resources.limits.memory'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv018

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0020
Check Name: Runs with low user ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsUser' > 10000
Resolution: Set 'containers[].securityContext.runAsUser' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv020

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0021
Check Name: Runs with low group ID
Severity: LOW
Message: Container '${{ secrets.ECR_REPOSITORY }}' of Deployment '${{ secrets.ECR_REPOSITORY }}' should set 'securityContext.runAsGroup' > 10000
Resolution: Set 'containers[].securityContext.runAsGroup' to an integer > 10000.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv021

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0030
Check Name: Default Seccomp profile not set
Severity: LOW
Message: Either Pod or Container should set 'securityContext.seccompProfile.type' to 'RuntimeDefault'
Resolution: Set 'spec.securityContext.seccompProfile.type', 'spec.containers[].securityContext.seccompProfile' and 'spec.initContainers[].securityContext.seccompProfile' to 'RuntimeDefault' or undefined.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv030

Comment on lines +20 to +27
- name: ${{ secrets.ECR_REPOSITORY }}
image: ${{ secrets.ECR_REGISTRY }}/${{ secrets.ECR_REPOSITORY }}:latest
ports:
- containerPort: 80
protocol: TCP
- containerPort: 3000
protocol: TCP
imagePullPolicy: Always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Aqua detected misconfiguration in your code

Misconfiguration ID: AVD-KSV-0106
Check Name: Container capabilities must only include NET_BIND_SERVICE
Severity: LOW
Message: container should drop all
Resolution: Set 'spec.containers[].securityContext.capabilities.drop' to 'ALL' and only add 'NET_BIND_SERVICE' to 'spec.containers[].securityContext.capabilities.add'.
[This comment was created by Aqua Pipeline]

Read more at https://avd.aquasec.com/misconfig/ksv106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant