Skip to content

Commit

Permalink
fix: missing namespace on clusterrolebinding in install manifests (#860)
Browse files Browse the repository at this point in the history
Signed-off-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: Jann Fischer <jann@mistrust.net>
  • Loading branch information
chengfang and jannfis committed Sep 11, 2024
1 parent 60b89f2 commit 89a261e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions docs/install/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ Argo CD is running. Don't worry, without any configuration, it will not start me
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml
```

!!! warning
The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different
namespace then make sure to update the namespace reference.

!!!note "A word on high availability"
It is not advised to run multiple replicas of the same Argo CD Image Updater
instance. Just leave the number of replicas at 1, otherwise weird side
Expand Down Expand Up @@ -70,6 +74,10 @@ kubectl create namespace argocd-image-updater
kubectl apply -n argocd-image-updater -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml
```

!!! warning
The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different
namespace then make sure to update the namespace reference.

!!!note "A word on high availability"
It is not advised to run multiple replicas of the same Argo CD Image Updater
instance. Just leave the number of replicas at 1, otherwise weird side
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ roleRef:
subjects:
- kind: ServiceAccount
name: argocd-image-updater
namespace: argocd
1 change: 1 addition & 0 deletions manifests/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ roleRef:
subjects:
- kind: ServiceAccount
name: argocd-image-updater
namespace: argocd
---
apiVersion: v1
kind: ConfigMap
Expand Down

0 comments on commit 89a261e

Please sign in to comment.