New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests for pkg/registry/client.go #839

Closed

chengfang opened this issue Aug 22, 2024 · 0 comments · Fixed by #865

Labels

test

Collaborator

chengfang commented Aug 22, 2024

Describe the bug
According to the test coverage report at https://app.codecov.io/gh/argoproj-labs/argocd-image-updater/blob/master/pkg%2Fregistry%2Fclient.go , some important code paths are not covered in function:

func (client *registryClient) TagMetadata(manifest distribution.Manifest, opts *options.ManifestOptions) (*tag.TagInfo, error) {

Need to add tests for those code paths in https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/registry/client.go#L198

chengfang added the test label

chengfang changed the title ~~Improve unit tests for~~ Improve unit tests for pkg/registry/client.go

chengfang mentioned this issue

tests: Improve unit tests for pkg/registry/client.go #865

Merged

jannfis closed this as completed in #865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment