Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Improve unit tests for pkg/registry/client.go #865

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

chengfang
Copy link
Collaborator

Closes #839

Signed-off-by: Cheng Fang <cfang@redhat.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (e92c4e6) to head (8d48880).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   74.39%   75.47%   +1.08%     
==========================================
  Files          31       31              
  Lines        3144     3144              
==========================================
+ Hits         2339     2373      +34     
+ Misses        669      636      -33     
+ Partials      136      135       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 13f01ec into argoproj-labs:master Sep 14, 2024
10 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve unit tests for pkg/registry/client.go
3 participants