Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix spell checking config #577

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Jun 21, 2023

No description provided.

@suzaku suzaku force-pushed the fix-spell-checking-config branch from 88505c2 to 873596c Compare June 21, 2023 09:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #577 (cac7354) into master (5366cc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   65.86%   65.86%           
=======================================
  Files          22       22           
  Lines        2045     2045           
=======================================
  Hits         1347     1347           
  Misses        569      569           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: satoru <satorulogic@gmail.com>
@suzaku suzaku force-pushed the fix-spell-checking-config branch from 873596c to cac7354 Compare June 21, 2023 10:11
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jannfis jannfis changed the title Fix spell checking config chore: Fix spell checking config Jul 6, 2023
@jannfis jannfis merged commit 61af526 into argoproj-labs:master Jul 6, 2023
ks-yim pushed a commit to ks-yim/argocd-image-updater that referenced this pull request Jul 9, 2023
Signed-off-by: satoru <satorulogic@gmail.com>
Signed-off-by: KS. Yim <ks.yim@linecorp.com>
jwhy89 pushed a commit to jwhy89/argocd-image-updater that referenced this pull request Aug 17, 2023
Signed-off-by: satoru <satorulogic@gmail.com>
Signed-off-by: Jarvis Yang <jarvis.yang@recurohealth.com>
jessebye pushed a commit to jessebye/argocd-image-updater that referenced this pull request Sep 1, 2023
Signed-off-by: satoru <satorulogic@gmail.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>
jessebye pushed a commit to jessebye/argocd-image-updater that referenced this pull request Sep 1, 2023
Signed-off-by: satoru <satorulogic@gmail.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

docs: Fixed typo (argoproj-labs#589)

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

chore: Preallocate space for slices with known size (argoproj-labs#575)

Signed-off-by: satoru <satorulogic@gmail.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

ci: Fix codegen and update kustomize to post-2.0 (argoproj-labs#590)

* ci: Fix codegen

Signed-off-by: jannfis <jann@mistrust.net>

* Fix tar call

Signed-off-by: jannfis <jann@mistrust.net>

---------

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

feat: Respect original parameter overrides with git write-back (argoproj-labs#573)

* Fix original override not respected

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* Add writeOverrides unittest

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* Add helm override commit test

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* lint

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* fix shadowed err

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

---------

Signed-off-by: KS. Yim <ks.yim@linecorp.com>
Co-authored-by: KS. Yim <ks.yim@linecorp.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

chore: Update to newer argocd version for better API compatibility (argoproj-labs#594)

* fix: update go mods to use newer argocd app definition

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

* fix deps and tests

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

* fix spelling

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

---------

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

chore(deps): upgrade dependencies for fix vulnerabilities (argoproj-labs#599)

Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix: tighten securityContext to comply with restricted PSS (argoproj-labs#600)

makes argocd-image-updater compatible with restricted Pod Security Standard

Signed-off-by: Takeo Sawada <myc.monad@gmail.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

feat: Add possibility to specify write-back GIT repository as annotation (argoproj-labs#424)

* Add possibility to specify write-back GIT repository as annotation.

Signed-off-by: flozzone <flozzone@gmail.com>

* Update golangci-lint to 1.52.2.

Signed-off-by: flozzone <flozzone@gmail.com>

* Replace deprecated golangci linters with 'unused' linter.

Signed-off-by: flozzone <flozzone@gmail.com>

* Fix Goimport issues.

Signed-off-by: flozzone <flozzone@gmail.com>

---------

Signed-off-by: flozzone <flozzone@gmail.com>
Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix: support ocischema.DeserializedImageIndex in registry client

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix test

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix: update go mods to use newer argocd app definition

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix deps and tests

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

merge master

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix go mods

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

refactor: use shared function to reduce duplication

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix: update go mods to use newer argocd app definition

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix deps and tests

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

merge master

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

fix go mods

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

Fix after rebase

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

chore: Fix spell checking config (argoproj-labs#577)

Signed-off-by: satoru <satorulogic@gmail.com>

docs: Fixed typo (argoproj-labs#589)

chore: Preallocate space for slices with known size (argoproj-labs#575)

Signed-off-by: satoru <satorulogic@gmail.com>

ci: Fix codegen and update kustomize to post-2.0 (argoproj-labs#590)

* ci: Fix codegen

Signed-off-by: jannfis <jann@mistrust.net>

* Fix tar call

Signed-off-by: jannfis <jann@mistrust.net>

---------

Signed-off-by: jannfis <jann@mistrust.net>

feat: Respect original parameter overrides with git write-back (argoproj-labs#573)

* Fix original override not respected

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* Add writeOverrides unittest

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* Add helm override commit test

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* lint

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

* fix shadowed err

Signed-off-by: KS. Yim <ks.yim@linecorp.com>

---------

Signed-off-by: KS. Yim <ks.yim@linecorp.com>
Co-authored-by: KS. Yim <ks.yim@linecorp.com>

chore: Update to newer argocd version for better API compatibility (argoproj-labs#594)

* fix: update go mods to use newer argocd app definition

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

* fix deps and tests

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

* fix spelling

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

---------

Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>

chore(deps): upgrade dependencies for fix vulnerabilities (argoproj-labs#599)

Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com>

fix: tighten securityContext to comply with restricted PSS (argoproj-labs#600)

makes argocd-image-updater compatible with restricted Pod Security Standard

Signed-off-by: Takeo Sawada <myc.monad@gmail.com>
xescab pushed a commit to xescab/argocd-image-updater that referenced this pull request Sep 8, 2023
Signed-off-by: satoru <satorulogic@gmail.com>
Signed-off-by: Francesc Arbona <francesc.arbona@global.ntt>
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
Signed-off-by: satoru <satorulogic@gmail.com>
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Signed-off-by: satoru <satorulogic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants