-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added release process #827
docs: added release process #827
Conversation
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
=======================================
Coverage 73.53% 73.53%
=======================================
Files 31 31
Lines 3140 3140
=======================================
Hits 2309 2309
Misses 695 695
Partials 136 136 ☔ View full report in Codecov by Sentry. |
@jannfis @chengfang could you please also review it? I want make sure that process is clear https://argocd-image-updater--827.org.readthedocs.build/en/827/contributing/releasing/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks so much!
I made some observations, please see below.
Finally run | ||
|
||
``` | ||
./hack/create-release-pr.sh origin | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted that this script needs the GitHub CLI. It also uses something called semver-cli
, which I've never heard of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the requirements in the documentation page itself.
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Explain how to make releases for Argo Image updater