Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applications in all Namespaces when trying to update #831

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sribiere-jellysmack
Copy link
Contributor

It looks like I closed PR 800 (I don't remember doing that)

So I Recreated it

For now, AIU only lists application in ArgoCD Namespace before trying to update them

This PR allows AIU to fetch all namespaces for annotated applications

Signed-off-by: Sebastien RIBIERE <sebastien.ribiere.ext@jellysmack.com>
Signed-off-by: Sebastien RIBIERE <sebastien.ribiere.ext@jellysmack.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (60b89f2) to head (ac2ac95).

Files with missing lines Patch % Lines
cmd/run.go 12.50% 7 Missing ⚠️
cmd/test.go 0.00% 1 Missing ⚠️
cmd/util.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   74.39%   74.29%   -0.11%     
==========================================
  Files          31       31              
  Lines        3144     3151       +7     
==========================================
+ Hits         2339     2341       +2     
- Misses        669      674       +5     
  Partials      136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sebastien RIBIERE <sebastien.ribiere.ext@jellysmack.com>
@sribiere-jellysmack
Copy link
Contributor Author

Let's answer @jannfis ' comment on PR800

Now there is a parameter to chose wether we want namespaced or clusterwide listing.
Regarding CLusterRol and Binding, I will submit a PR on https://github.com/argoproj/argo-helm

@sribiere-jellysmack
Copy link
Contributor Author

Any comments please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants