Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting new value in Helm values file #838

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

jnovick
Copy link
Contributor

@jnovick jnovick commented Aug 22, 2024

  • This was previously supported, but broke when the function was refactored to preserve order of yaml file (Fix/helm values wbc #748)
  • Behavior does not change if overriding an existing value
  • If the values file is empty or does not have a previous value, add the value instead of erroring

@jnovick jnovick force-pushed the allow-adding-new-helm-value branch 2 times, most recently from 104c19d to 94ee4ad Compare August 22, 2024 06:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (0c9c0a9) to head (9090f65).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
- Coverage   73.47%   73.46%   -0.01%     
==========================================
  Files          31       31              
  Lines        3114     3128      +14     
==========================================
+ Hits         2288     2298      +10     
- Misses        692      694       +2     
- Partials      134      136       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* This was previously supported, but broke when the function was
  refactored to preserve order of yaml file
* Behavior does not change if overriding an existing value
* If the values file is empty or does not have a previous value, add the
  value instead of erroring

Signed-off-by: Joshua Novick <joshua.novick@hunters.ai>
@jnovick jnovick force-pushed the allow-adding-new-helm-value branch from 94ee4ad to cd276ac Compare August 22, 2024 12:40
@jnovick
Copy link
Contributor Author

jnovick commented Aug 22, 2024

@jannfis I have published an image to my own registry and tested it works as desired and the tests also show that it works. Let me know if you want me to make any changes.

@askhari If you have concerns, let me know since you implemented the change that broke the ability to write to a new file. I want to make sure you are aware in case this breaks a behavior that you are expecting.

@askhari
Copy link
Contributor

askhari commented Aug 29, 2024

@jannfis I have published an image to my own registry and tested it works as desired and the tests also show that it works. Let me know if you want me to make any changes.

@askhari If you have concerns, let me know since you implemented the change that broke the ability to write to a new file. I want to make sure you are aware in case this breaks a behavior that you are expecting.

@jnovick , thank you for the notice :) . I see that now this fix is already merged. That's good news.
I didn't realize that I broke that behavior somehow. I tried to implement that piece of code to use its own workflow to avoid breaking things :| . As it was a new feature, at the beginning it was not intended to create new files or entries in the file because we didn't have that requirement. So, it's great that now it will allow to add new keys if needed.

Thank you for your help and improvement of the code :) .

@chengfang chengfang merged commit 8c9e269 into argoproj-labs:master Aug 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants