fix: failed to process a full image-spec annotation with git writeback to helmvalues #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 73.48% 73.50% +0.01%
==========================================
Files 31 31
Lines 3142 3144 +2
==========================================
+ Hits 2309 2311 +2
Misses 695 695
Partials 138 138 ☔ View full report in Codecov by Sentry. |
|
@chengfang can you please resolve the conflict? |
…k to helmvalues Signed-off-by: Cheng Fang <cfang@redhat.com>
chengfang
force-pushed
the
helm.image-spec
branch
from
26a34df
to
25d55fa
Compare
chengfang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840