feat: Migrate dex to spec.sso #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jaideep Rao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jaideepr97
changed the title
4 tasks
added 8 commits
November 29, 2021 09:54
jaideepr97
force-pushed
the
migrate-dex-to-spec.sso
branch
from
46aa903
to
d53342d
Compare
|
@jaideepr97 PTAL at failing test. |
jaideepr97
force-pushed
the
migrate-dex-to-spec.sso
branch
from
d3c0549
to
e808805
Compare
2 tasks
…ator into migrate-dex-to-spec.sso
iam-veeramalla
approved these changes
Dec 21, 2021
4 tasks
jaideepr97
added a commit
to jaideepr97/argocd-operator
that referenced
this pull request
Dec 22, 2021
This reverts commit 6de5fc2.
wtam2018
pushed a commit
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
This is a PR to unify SSO configuration across dex and keycloak in Argo CD CR. See https://issues.redhat.com/browse/GITOPS-1331 for details
This PR also removes the
DISABLE_DEXenv var toggle and makes.spec.ssothe only toggle to configure DexHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #483
How to test changes / Special notes to the reviewer: