-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate dex to spec.sso #488
feat: Migrate dex to spec.sso #488
Conversation
Jaideep Rao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
46aa903
to
d53342d
Compare
@jaideepr97 PTAL at failing test. |
d3c0549
to
e808805
Compare
…ator into migrate-dex-to-spec.sso
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , Thanks :)
This reverts commit 6de5fc2.
What type of PR is this?
What does this PR do / why we need it:
This is a PR to unify SSO configuration across dex and keycloak in Argo CD CR. See https://issues.redhat.com/browse/GITOPS-1331 for details
This PR also removes the
DISABLE_DEX
env var toggle and makes.spec.sso
the only toggle to configure DexHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #483
How to test changes / Special notes to the reviewer: