chore: Refactor tests to utilize github.com/stretchr/testify #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
wtam2018
reviewed
Jan 6, 2022
|
|
||
| // Check if the CLuster Role gets deleted | ||
| os.Unsetenv("ARGOCD_CLUSTER_CONFIG_NAMESPACES") | ||
| _, err = r.reconcileClusterRole(workloadIdentifier, expectedRules, a) | ||
| assert.ErrorContains(t, r.Client.Get(context.TODO(), types.NamespacedName{Name: clusterRoleName}, reconciledClusterRole), "not found") | ||
| //assert.ErrorContains(t, r.Client.Get(context.TODO(), types.NamespacedName{Name: clusterRoleName}, reconciledClusterRole), "not found") | ||
| //TODO: https://github.com/stretchr/testify/pull/1022 introduced ErrorContains, but is not yet available in a tagged release. Revert to ErrorContains once this becomes available |
There was a problem hiding this comment.
Is this comment still valid? It looks like that PR has been merged.
There was a problem hiding this comment.
Yeah. Still valid. It's been merged. But doesn't look like it's made its way into a versioned release of testify yet.
wtam2018
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does this PR do / why we need it:
This PR continues the initial work to refactor tests to utilize github.com/stretchr/testify/assert
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Continues to address #302
How to test changes / Special notes to the reviewer:
make test
**Additional Info:
There are tests that can be further refactored at this point, but the primary point of this PR is to at least standardize on the github.com/testify/assert library throughout all of the tests prior to making any larger changes.