Remove Python 3.8 support (#1202)

**Pull Request Checklist** - [x] Fixes #969 - [ ] ~Tests added~ - [ ] ~Documentation/examples added~ - [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title **Description of PR** Removes 3.8 support which is end of life next month. The commits are mostly 1-1 with the list of tasks in the issue, most of the changes are automatic, only some manual changes to the `roundtrip` function along with configs etc. --------- Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
argoproj-labs · Sep 17, 2024 · af5b19f · af5b19f
1 parent e8635f9
commit af5b19f
Show file tree

Hide file tree

Showing 199 changed files with 305 additions and 1,849 deletions.
diff --git a/.github/workflows/cicd.yaml b/.github/workflows/cicd.yaml
@@ -105,10 +105,10 @@ jobs:
       - name: Install poetry
         run: pipx install poetry
 
-      - name: setup python 3.8
+      - name: setup python 3.9
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
           cache: "poetry"
 
       - name: Install dependencies

diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
@@ -8,10 +8,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install base dependencies
         run: |
           python -m pip install --upgrade pip

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -11,10 +11,10 @@ jobs:
     environment: pypi-prod
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Python 3.8
+      - name: Set up Python 3.9
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install base dependencies
         run: |
           python -m pip install --upgrade pip

diff --git a/Makefile b/Makefile
@@ -11,9 +11,9 @@ install: ## Run poetry install with all extras for development
 	@poetry env use system
 	@poetry install --all-extras
 
-.PHONY: install-3.8
-install-3.8: ## Install python3.8 for generating test data
-	@poetry env use 3.8
+.PHONY: install-3.9
+install-3.9: ## Install and use Python 3.9 for generating test data
+	@poetry env use 3.9
 	@poetry install --all-extras
 
 .PHONY: ci
@@ -53,7 +53,7 @@ workflows-models: ## Generate the Workflows models portion of Argo Workflows
 	@poetry run datamodel-codegen \
 		--input $(SPEC_PATH) \
 		--snake-case-field \
-		--target-python-version 3.8 \
+		--target-python-version 3.9 \
 		--output src/hera/workflows/models \
 		--output-model-type pydantic.BaseModel \
 		--base-class hera.shared._pydantic.BaseModel \
@@ -76,7 +76,7 @@ events-models: ## Generate the Events models portion of Argo Workflows
 	@poetry run datamodel-codegen \
 		--input $(SPEC_PATH) \
 		--snake-case-field \
-		--target-python-version 3.8 \
+		--target-python-version 3.9 \
 		--output src/hera/events/models \
 		--output-model-type pydantic.BaseModel \
 		--base-class hera.shared._pydantic.BaseModel \
@@ -127,7 +127,7 @@ regenerate-example: install
 
 .PHONY: regenerate-test-data
 regenerate-test-data:  ## Regenerates the test data from upstream examples and runs tests, report missing examples
-regenerate-test-data: install-3.8
+regenerate-test-data: install-3.9
 	find examples -name "*.yaml" -type f -delete
 	HERA_REGENERATE=1 make test examples
 	@poetry run python -m pytest -k test_for_missing_examples --runxfail

diff --git a/docs/examples/workflows/artifacts/artifact.md b/docs/examples/workflows/artifacts/artifact.md
@@ -64,7 +64,7 @@ task, consumer, takes this artifact, places it at its own `/file` path, and prin
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -79,7 +79,7 @@ task, consumer, takes this artifact, places it at its own `/file` path, and prin
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/artifacts/artifact_with_fanout.md b/docs/examples/workflows/artifacts/artifact_with_fanout.md
@@ -85,7 +85,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -102,7 +102,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -121,7 +121,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/any_success_all_fail.md b/docs/examples/workflows/dags/any_success_all_fail.md
@@ -83,7 +83,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -103,7 +103,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -120,7 +120,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/callable_dag.md b/docs/examples/workflows/dags/callable_dag.md
@@ -65,7 +65,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/callable_dag_with_param_get.md b/docs/examples/workflows/dags/callable_dag_with_param_get.md
@@ -79,7 +79,7 @@
           - examples.workflows.dags.callable_dag_with_param_get:hello_with_output
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - dag:
           tasks:

diff --git a/docs/examples/workflows/dags/complex_deps.md b/docs/examples/workflows/dags/complex_deps.md
@@ -75,7 +75,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/conditional.md b/docs/examples/workflows/dags/conditional.md
@@ -66,7 +66,7 @@ This example showcases conditional execution on success, failure, and error
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -80,7 +80,7 @@ This example showcases conditional execution on success, failure, and error
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -90,7 +90,7 @@ This example showcases conditional execution on success, failure, and error
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/dag_conditional_on_task_status.md b/docs/examples/workflows/dags/dag_conditional_on_task_status.md
@@ -62,7 +62,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -74,7 +74,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -84,7 +84,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/dag_with_script_output_param_passing.md b/docs/examples/workflows/dags/dag_with_script_output_param_passing.md
@@ -67,7 +67,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -81,7 +81,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/dag_with_script_param_passing.md b/docs/examples/workflows/dags/dag_with_script_param_passing.md
@@ -54,7 +54,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -67,7 +67,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/dags/on_exit.md b/docs/examples/workflows/dags/on_exit.md
@@ -44,7 +44,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys
@@ -74,7 +74,7 @@
         script:
           command:
           - python
-          image: python:3.8
+          image: python:3.9
           source: |-
             import os
             import sys

diff --git a/docs/examples/workflows/experimental/new_dag_decorator_artifacts.md b/docs/examples/workflows/experimental/new_dag_decorator_artifacts.md
@@ -95,7 +95,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - dag:
           tasks:

diff --git a/docs/examples/workflows/experimental/new_dag_decorator_inner_dag.md b/docs/examples/workflows/experimental/new_dag_decorator_inner_dag.md
@@ -97,7 +97,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - inputs:
           parameters:
@@ -119,7 +119,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - dag:
           tasks:

diff --git a/docs/examples/workflows/experimental/new_dag_decorator_params.md b/docs/examples/workflows/experimental/new_dag_decorator_params.md
@@ -127,7 +127,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - inputs:
           parameters:
@@ -152,7 +152,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - dag:
           tasks:

diff --git a/docs/examples/workflows/experimental/new_decorators_basic_script.md b/docs/examples/workflows/experimental/new_decorators_basic_script.md
@@ -65,7 +65,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - inputs:
           parameters:
@@ -89,7 +89,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
     ```
 
diff --git a/docs/examples/workflows/experimental/new_steps_decorator_with_parallel_steps.md b/docs/examples/workflows/experimental/new_steps_decorator_with_parallel_steps.md
@@ -101,7 +101,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - inputs:
           parameters:
@@ -124,7 +124,7 @@
             value: /tmp/hera-outputs
           - name: hera__script_pydantic_io
             value: ''
-          image: python:3.8
+          image: python:3.9
           source: '{{inputs.parameters}}'
       - inputs:
           parameters: