Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic template ref steps/tasks #1097

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

elliotgunton
Copy link
Collaborator

  • Within a DAG/Steps function, when calling functions that are decorated as templates belonging to other [Cluster]WorkflowTemplates, we generate a step/task that sets the TemplateRef based on the WorkflowTemplate name and the template name, as well as setting cluster_scope. Arguments are set as normal

Pull Request Checklist

* Within a DAG/Steps function, when calling functions that are decorated as
templates belonging to other [Cluster]WorkflowTemplates, we generate a
step/task that sets the TemplateRef based on the WorkflowTemplate name
and the template name, as well as setting cluster_scope. Arguments are set as
normal

Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
@elliotgunton elliotgunton added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Jun 12, 2024
@elliotgunton elliotgunton linked an issue Jun 12, 2024 that may be closed by this pull request
@sambhav sambhav merged commit 3b8b159 into new-container-decorator Jun 12, 2024
7 checks passed
@sambhav sambhav deleted the auto-template-refs branch June 12, 2024 09:58
elliotgunton added a commit that referenced this pull request Jun 12, 2024
**Pull Request Checklist**
- [x] Fixes #1065 
- [x] Tests added
- [x] Documentation/examples added
- [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**
Adds the container decorator, and the special `path` function on Outputs
Also adds template refs per #1097 

---------

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEP0001 - Automatic TemplateRef Step/Task
2 participants