Skip to content

Commit

Permalink
Revert "feat: exclude Endpoints and EndpointSlices Kubernetes resourc…
Browse files Browse the repository at this point in the history
…e by default" (#20334)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
  • Loading branch information
agaudreault authored Oct 10, 2024
1 parent 8ebf4a8 commit 29c59ab
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion docs/operator-manual/declarative-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ stringData:

## Resource Exclusion/Inclusion

Resources can be excluded from discovery and sync so that Argo CD is unaware of them. For example, the apiGroup/kind `events.k8s.io/*`, `metrics.k8s.io/*`, `coordination.k8s.io/Lease`, `""/Endpoints` and `discovery.k8s.io/EndpointSlice` are always excluded. Use cases:
Resources can be excluded from discovery and sync so that Argo CD is unaware of them. For example, the apiGroup/kind `events.k8s.io/*`, `metrics.k8s.io/*` and `coordination.k8s.io/Lease` are always excluded. Use cases:

* You have temporal issues and you want to exclude problematic resources.
* There are many of a kind of resources that impacts Argo CD's performance.
Expand Down
2 changes: 0 additions & 2 deletions util/settings/resources_filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ var coreExcludedResources = []FilteredResource{
{APIGroups: []string{"events.k8s.io", "metrics.k8s.io"}},
{APIGroups: []string{""}, Kinds: []string{"Event"}},
{APIGroups: []string{"coordination.k8s.io"}, Kinds: []string{"Lease"}},
{APIGroups: []string{""}, Kinds: []string{"Endpoints"}},
{APIGroups: []string{"discovery.k8s.io"}, Kinds: []string{"EndpointSlice"}},
}

type ResourcesFilter struct {
Expand Down

0 comments on commit 29c59ab

Please sign in to comment.