fix: Add logic to handle for f.Close() for util/db (#9963) (#10127)

Signed-off-by: xin.li <xin.li@daocloud.io>
argoproj · Jul 28, 2022 · 85b4dc3 · 85b4dc3
1 parent ea5063d
commit 85b4dc3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/util/db/gpgkeys.go b/util/db/gpgkeys.go
@@ -24,7 +24,12 @@ func validatePGPKey(keyData string) (*appsv1.GnuPGPublicKey, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer f.Close()
+	defer func() {
+		err = f.Close()
+		if err != nil {
+			log.Errorf("error closing file %q: %v", f.Name(), err)
+		}
+	}()
 
 	parsed, err := gpg.ValidatePGPKeys(f.Name())
 	if err != nil {