add test

argoproj · Oct 16, 2023 · b23cc86 · b23cc86
1 parent 0d9d265
commit b23cc86
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/reposerver/repository/repository.go b/reposerver/repository/repository.go
@@ -2092,7 +2092,7 @@ func walkHelmValueFilesInPath(root string, valuesFiles *[]string) filepath.WalkF
 		if strings.Contains(filename, "values") && (fileNameExt == ".yaml" || fileNameExt == ".yml") {
 			relPath, err := filepath.Rel(root, path)
 			if err != nil {
-				return fmt.Errorf("error traversing path from %s: %w", path, err)
+				return fmt.Errorf("error traversing path from %s to %s: %w", root, path, err)
 			}
 			*valuesFiles = append(*valuesFiles, relPath)
 		}

diff --git a/reposerver/repository/repository_test.go b/reposerver/repository/repository_test.go
@@ -2678,6 +2678,13 @@ func Test_walkHelmValueFilesInPath(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Len(t, files, 4)
 	})
+	t.Run("unrelated root", func(t *testing.T) {
+		var files []string
+		root := "./testdata/values-files"
+		unrelated_root := "/different/root/path"
+		err := filepath.Walk(root, walkHelmValueFilesInPath(unrelated_root, &files))
+		assert.Error(t, err)
+	})
 }
 
 func Test_populateHelmAppDetails(t *testing.T) {