Allow values to be added & interpolated in Git and SCM generators #10751
Labels
enhancement
New feature or request
Comments
9 tasks
crenshaw-dev
added a commit
that referenced
this issue
May 29, 2023
… Git and SCM generators (#10751) (#10754) * Factor out value interpolation Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Pass on useGoTemplate directly Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add values for git directories & files Interpolate values in git files generator Document git generator value interpolation Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Consolidate value interpolation tests Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Enable multiple testcases for SCM provider test Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add values to SCM provider & document Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add merge generator example Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Codegen - run to autogen docs & code Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Re-run codegen Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Re-do codegen Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Note about unsupported nested merge Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> --------- Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Christoph Girstenbrei <christoph.girstenbrei@retarus.de> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this issue
Aug 9, 2023
… Git and SCM generators (argoproj#10751) (argoproj#10754) * Factor out value interpolation Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Pass on useGoTemplate directly Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add values for git directories & files Interpolate values in git files generator Document git generator value interpolation Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Consolidate value interpolation tests Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Enable multiple testcases for SCM provider test Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add values to SCM provider & document Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add merge generator example Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Codegen - run to autogen docs & code Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Re-run codegen Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Re-do codegen Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Note about unsupported nested merge Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> --------- Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Christoph Girstenbrei <christoph.girstenbrei@retarus.de> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this issue
Dec 16, 2023
… Git and SCM generators (argoproj#10751) (argoproj#10754) * Factor out value interpolation Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Pass on useGoTemplate directly Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add values for git directories & files Interpolate values in git files generator Document git generator value interpolation Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Consolidate value interpolation tests Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Enable multiple testcases for SCM provider test Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add values to SCM provider & document Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Add merge generator example Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Codegen - run to autogen docs & code Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Re-run codegen Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Re-do codegen Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> * Note about unsupported nested merge Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> --------- Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Christoph Girstenbrei <christoph.girstenbrei@retarus.de> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
After reading #9978 , I figured it would be nice to extend the functionality to set and interpolate
valuesfrom the cluster ApplicationSet generator to other generators as well.Motivation
I have multiple clusters and multiple applications configured in their own repositories. I want these applications to be able to deploy themselves to clusters by having a dedicated branch per cluster.
One option is to use the cluster generator to discover configured clusters. Assuming those have a
metadata.labels.locationset, the SCM generator could discover those branches.To combine those two, I could then have a
values.selectorlabel. The cluster generator setsvalues.selector = metadata.labels.locationwhile the SCM generator doesvalues.selector = branch. This then can be used by the merge generator to combine settings for each.Proposal
Re-use the already existing interpolation from the cluster generator and do the same for other interesting generators.
The text was updated successfully, but these errors were encountered: